This repository has been archived by the owner on May 6, 2022. It is now read-only.
Add PyTorch model abstraction #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
space-pope
reviewed
Jun 30, 2021
There was a problem hiding this comment.
This allows PyTorch models to be loaded, but doesn't do much with them. The readme instructions explain how to load a model, but not how to use one in the context of Spokestack. Are further integrations/instructions planned for future PRs?
In other words, this is more of a library contributor/developer feature as written, something that you'd mention in tutorials about building your own integrations rather than the readme.
|
This is intended to be the complement to the TFLite model abstraction. Ultimately, I think we could let the user choose between TensorFlow or PyTorch. I will take out the documentation in the README, because like you said only a contributor really needs to know about this class. |
space-pope
approved these changes
Jun 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyTorch is a popular ML framework in Python. Users may want to be able to use jit traced PyTorch models with Spokestack. This abstraction offers users that ability.