[Security Solution] Security Assistant: Data Quality dashboard _New Chat_ button & API updates #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updates the `useAssistantOverlay` API - `NewChat` takes an optional `children` prop - added `NewChatById` component - increases test coverage
spong
reviewed
May 31, 2023
Comment on lines
+25
to
+28
| * USE THIS WHEN: You want to register context in one part of the tree, and then show | ||
| * a _New chat_ button in another part of the tree without passing around the data, or when | ||
| * you want to build a custom `New chat` button with features not not provided by the | ||
| * `NewChat` component. |
spong
reviewed
May 31, 2023
Comment on lines
+22
to
+24
| * `analyzeMarkdown` is a helper that enriches content returned from a query | ||
| * with action buttons | ||
| * |
There was a problem hiding this comment.
Ty! Hoping we can remove this entirely once adding the markdown processor for codeblock actions
spong
approved these changes
May 31, 2023
spong
pushed a commit
that referenced
this pull request
Oct 3, 2023
elastic#167877) Revert of elastic#164574 Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
spong
pushed a commit
that referenced
this pull request
Jan 2, 2024
elastic#170411) …2282) (elastic#169580)" This reverts commit a382569.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Security Solution] Security Assistant: Data Quality Dashboard New Chat button & API updates
useAssistantOverlayAPINewChattakes an optionalchildrenpropNewChatByIdcomponent