Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hardcoded annotation classes configurable #7

Closed
gabizou opened this issue May 29, 2018 · 1 comment
Closed

Make hardcoded annotation classes configurable #7

gabizou opened this issue May 29, 2018 · 1 comment

Comments

@gabizou
Copy link
Member

gabizou commented May 29, 2018

Because event impl gen has more uses than just the SpongeAPI events, I'd hope that we'd be able to make it configurable through gradle to use a particular set of annotations through the gradle build configuration files or something thereof (just like how the SpongeEventFactory is set). Ideally, this would allow for more than just SpongeAPI projects to be able to use the plugin. If the annotations are meant for specific needs, can make them hard values that are needed to use the plugin.

liach added a commit to liachmodded/event-impl-gen that referenced this issue Jan 6, 2019
Signed-off-by: liach <liach@users.noreply.github.com>
@liach
Copy link
Contributor

liach commented Jan 6, 2019

In #5, I allowed each event impl generation task to specify its own set of inclusive/exclusive annotations. Is that desirable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants