Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpongeEventHandler is inconsistent #174

Closed
coelho opened this issue Sep 17, 2014 · 3 comments
Closed

SpongeEventHandler is inconsistent #174

coelho opened this issue Sep 17, 2014 · 3 comments

Comments

@coelho
Copy link

coelho commented Sep 17, 2014

The annotation org.spongepowered.api.event.SpongeEventHandler is inconsistent with the rest of the API. To fix this, we can either:

  1. Change it to org.spongepowered.api.event.EventHandler
  2. Change other annotations like org.spongepowered.api.plugin.Plugin to, for example, org.spongepowered.api.plugin.SpongePlugin

Opinions?
@AedDev
Copy link

AedDev commented Sep 17, 2014

I agree with the first point. But why change from Plugin to SpongePlugin? I see no reason to do that ...

@coelho
Copy link
Author

coelho commented Sep 17, 2014

It's just an alternative option that will also accomplish the goal of making things consistent. I'm much more in favor of the first option however.

AedDev added a commit to AedDev/SpongeAPI that referenced this issue Sep 17, 2014
@AedDev
Solved issue SpongePowered#174
e02691a
@AedDev AedDev mentioned this issue Sep 17, 2014
Closed
@maxov
Copy link
Contributor

maxov commented Nov 7, 2014

After some discussion in #175 and IRC, it has been resolved to rename SpongeEventHandler to Subscribe. See 4ed9d79.

@maxov maxov closed this as completed Nov 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@coelho @maxov @AedDev