Metadata: Fix the form helper so it doesn't mutate arguments

companionstudio · Oct 28, 2014 · fd4ae7b · fd4ae7b
1 parent 73c9dcd
commit fd4ae7b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/lib/islay/form_builder.rb b/lib/islay/form_builder.rb
@@ -43,8 +43,9 @@ def metadata(&blk)
     # @return String
     #
     # @todo Support other types like URL, Email, etc.
-    def metadata_input(attribute_name, options = {}, &block)
+    def metadata_input(attribute_name, incoming_opts = {}, &block)
       metaopts = object.metadata_attributes[attribute_name]
+      options = incoming_opts.dup
 
       unless options.has_key?(:as)
         options[:as] = case metaopts[:type]

diff --git a/lib/islay/metadata.rb b/lib/islay/metadata.rb
@@ -156,6 +156,7 @@ def define_validations(name, type, primitive, opts)
 
       def define_attribute(name, type, primitive, opts)
         raise ExistingAttributeError.new(name, @model) if column_names.include?(name)
+
         reader = case primitive
         when :array
           %{
@@ -171,7 +172,9 @@ def define_attribute(name, type, primitive, opts)
 
         writer = case primitive
         when :array
-          %{self[_metadata.col] = data_column.merge('#{name}' => v)}
+          %{
+            self[_metadata.col] = data_column.merge('#{name}' => v)
+          }
         else
           %{self[_metadata.col] = data_column.merge('#{name}' => _metadata.coerce_#{primitive}(v))}
         end

diff --git a/lib/islay/version.rb b/lib/islay/version.rb
@@ -1,3 +1,3 @@
 module Islay
-  VERSION = "1.1.1"
+  VERSION = "1.1.2"
 end