Adjust for pep8 package rename. #2
Conversation
|
See upstream change at https://gitlab.com/pycqa/flake8/commit/1db863e60a4693d702ad918afeb905d4ed119f20 Quote:
|
|
Does that mean we're just waiting for a new flake8 release? It still seems reasonable for this package to use the actual upstream names though, doesn't it? |
|
Absolutely, I think it's important to merge this pull request and make a new release as fast as possible. My post was just adding some information to strengthen your patch. |
| @@ -4,13 +4,17 @@ | |||
| """ | |||
| __version__ = 0.2 | |||
|
|
|||
| import pep8 | |||
| try: | |||
There was a problem hiding this comment.
I would argue that this should simply be:
from pycodestyle import StandardReport, noqa
with an additional change to the setup.py file (https://github.com/spookylukey/flake8-respect-noqa/blob/master/setup.py#L34) to add an explicit dependency on pycodestyle >= 2.0. And / or change the setup.py file to require flake8 >= 2.6.
There was a problem hiding this comment.
It's very little work to support both pep8 and pycodestyle. I don't see a strong reason against supporting both.
There was a problem hiding this comment.
I agree with @sigmavirus24 , this looks fine.
There was a problem hiding this comment.
One concern you might have @spookylukey is that pep8 is tried first. If someone upgrades from flake8 <2.6.0 to >=2.6.0, they will likely have both pep8 and pycodestyle installed. You might want to try pycodestyle first then do pep8, but I'm not sure if this will really provide you with any bugs or not.
|
I did a new release to PyPI as well. |
Closes #1