Handle exact alarms on android >= 14 #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashirRajah
reviewed
Apr 18, 2024
| @@ -90,6 +95,14 @@ public void initialize (CordovaInterface cordova, CordovaWebView webView) { | |||
| public void onResume (boolean multitasking) { | |||
| super.onResume(multitasking); | |||
| deviceready(); | |||
|
|
|||
| Context context = cordova.getActivity().getApplicationContext(); | |||
There was a problem hiding this comment.
Should we not use a runtime request permission instead of navigating to the settings page? Permissions like for pictures and Geo-location at the start of the app?
zfir
reviewed
Apr 19, 2024
|
|
||
| Context context = cordova.getActivity().getApplicationContext(); | ||
| AlarmManager alarmManager = (AlarmManager) context.getSystemService(Context.ALARM_SERVICE); | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S && !alarmManager.canScheduleExactAlarms()) { |
There was a problem hiding this comment.
Suggested change
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S && !alarmManager.canScheduleExactAlarms()) { | |
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S && alarmManager.canScheduleExactAlarms()) { |
?
Do we need the second condition?
There was a problem hiding this comment.
alarmManager.canScheduleExactAlarms() checks whether the app has the appropriate SCHEDULE_EXACT_ALARM permission or not
| AlarmManager alarmManager = (AlarmManager) context.getSystemService(Context.ALARM_SERVICE); | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S && !alarmManager.canScheduleExactAlarms()) { | ||
| Intent intent = new Intent(android.provider.Settings.ACTION_REQUEST_SCHEDULE_EXACT_ALARM); | ||
| intent.setData(Uri.fromParts("package", context.getPackageName(), null)); |
There was a problem hiding this comment.
Suggested change
| intent.setData(Uri.fromParts("package", context.getPackageName(), null)); |
There was a problem hiding this comment.
we should bind the intent to the app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCHEDULE_EXACT_ALARM permission is denied by default on android 14 and higher