Player score reset #1

Closed
sporksmith opened this Issue Jul 6, 2013 · 2 comments

Comments

Projects
None yet
1 participant
@sporksmith
Owner

sporksmith commented Jul 6, 2013

Twice when running the game, the player data was reset. This caused all calls to drop (since the Tropo sessionid's for the live calls were no longer in our database), and player scores to reset.

@sporksmith

This comment has been minimized.

Show comment
Hide comment
@sporksmith

sporksmith Jul 6, 2013

Owner

After reviewing the server logs, it appears the player data was manually reset through the dashboard page. (i.e., posting to dance_ave/dash). I suspect this was done by accidentally re-POSTing after a reset by refreshing the dashboard page to see the updated player scores. While the browser should (and probably did) warn about re-POSTing data, the consequences may not have been clear.

To avoid this, we should use the Post-Redirect-Get pattern.

Owner

sporksmith commented Jul 6, 2013

After reviewing the server logs, it appears the player data was manually reset through the dashboard page. (i.e., posting to dance_ave/dash). I suspect this was done by accidentally re-POSTing after a reset by refreshing the dashboard page to see the updated player scores. While the browser should (and probably did) warn about re-POSTing data, the consequences may not have been clear.

To avoid this, we should use the Post-Redirect-Get pattern.

@sporksmith

This comment has been minimized.

Show comment
Hide comment
@sporksmith

sporksmith Jul 6, 2013

Owner

We now use the Post-Redirect-Get pattern to avoid this (commit 28a9891)

Owner

sporksmith commented Jul 6, 2013

We now use the Post-Redirect-Get pattern to avoid this (commit 28a9891)

@sporksmith sporksmith closed this Jul 6, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment