Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

Add mfa functionality #1

Merged
merged 5 commits into from
May 5, 2014
Merged

Add mfa functionality #1

merged 5 commits into from
May 5, 2014

Conversation

ehlertij
Copy link
Collaborator

@ehlertij ehlertij commented May 2, 2014

The IAM permissions changes are simple for this:

{
  "Statement": [
    {
      "Effect": "Allow",
      "Action": "*",
      "Resource": "*",
      "Condition":{
         "NumericLessThan":{"aws:MultiFactorAuthAge":"3600"}
      }
    }
  ]
}

The aws_keys.yml file will require another field:

:mfa_serial_number: arn:aws:iam::123456789012:mfa/user.name

@ehlertij
Copy link
Collaborator Author

ehlertij commented May 2, 2014

@anfleene want to review this?

end
rescue StandardError => e
puts e.class
puts e.message
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this error message useful when you don't have mfa configured? Otherwise I'd rather catch it before we even try.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah i guess it raises a custom exception MFATokenMissing thats probably good enough.

@anfleene
Copy link
Contributor

anfleene commented May 5, 2014

The only thing thats a bit weird is how epically it fails when you don't have an arn set. Otherwise this is totally awesome. and works as expected 👍

@anfleene
Copy link
Contributor

anfleene commented May 5, 2014

Here's the epic fail I'm talking about:
1 guardhouse-firewall-manager master zsh

@anfleene
Copy link
Contributor

anfleene commented May 5, 2014

Changes look good 👍 QA Passes :shipit:

ehlertij added a commit that referenced this pull request May 5, 2014
@ehlertij ehlertij merged commit 4e9f8d7 into master May 5, 2014
@ehlertij ehlertij deleted the mfa branch May 5, 2014 15:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants