This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
creates security groups if they don't already exist #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NickLaMuro will you code review this before I try to run it? |
| end | ||
|
|
||
| def self.missing_security_groups | ||
| missing_security_groups = config_security_groups - security_groups.map{|sg| sg[:name]} |
There was a problem hiding this comment.
The second part of this can be shorted to security_groups.map(&:name):
missing_security_groups = config_security_groups - security_groups.map(&:name)There was a problem hiding this comment.
this didn't work when running tests, but that could be because I screwed what :security_groups returns in my tests
There was a problem hiding this comment.
I misread that. It isn't a method each of the elements, but a key in a hash, so you are right and it wouldn't work. Carry on.
elliothursh
pushed a commit
that referenced
this pull request
Aug 26, 2014
creates security groups if they don't already exist
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates security groups on ec2 if they don't already exist.