Update time format to return fractional seconds #155

stevendaniels · 2019-03-25T14:05:13Z

Previously, the time would return seconds as integer values. This update returns milliseconds, too.

time = 3.141
sprintf('%0.000f', time)
# => "3"

sprintf('%.3f', time)
# => "3.141"

Before

After

Previously, the time would return seconds as integer values. This update returns milliseconds, too. ```ruby time = 3.141 sprintf('%0.000f', time) # => "3" sprintf('%.3f', time) # => "3.141" ```

stevendaniels · 2019-03-25T21:26:32Z

spec/ok_computer/check_spec.rb

@@ -64,7 +64,7 @@ module OkComputer

      context "#to_text" do
        it "combines the registrant_name, success, message, and execution time" do
-          expect(subject.to_text).to eq("#{subject.registrant_name}: PASSED #{subject.message} (5s)")
+          expect(subject.to_text).to eq("#{subject.registrant_name}: PASSED #{subject.message} (5.000s)")


pbyrne · 2019-03-26T13:41:34Z

v1.7.4 is released with these changes. Thanks for the contribution!

Update time format to return fractional seconds

3b0cdaf

Previously, the time would return seconds as integer values. This update returns milliseconds, too. ```ruby time = 3.141 sprintf('%0.000f', time) # => "3" sprintf('%.3f', time) # => "3.141" ```

pbyrne previously approved these changes Mar 25, 2019

View reviewed changes

Andy Fleener and others added 2 commits March 25, 2019 16:05

Merge branch 'master' into patch-1

d7b530f

fix specs

3740702

stevendaniels dismissed pbyrne’s stale review via 3740702 March 25, 2019 21:24

stevendaniels commented Mar 25, 2019

View reviewed changes

pbyrne approved these changes Mar 26, 2019

View reviewed changes

pbyrne merged commit 550405e into sportngin:master Mar 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update time format to return fractional seconds #155

Update time format to return fractional seconds #155

stevendaniels commented Mar 25, 2019

stevendaniels Mar 25, 2019

pbyrne commented Mar 26, 2019

Update time format to return fractional seconds #155

Update time format to return fractional seconds #155

Conversation

stevendaniels commented Mar 25, 2019

Before

After

stevendaniels Mar 25, 2019

Choose a reason for hiding this comment

pbyrne commented Mar 26, 2019