Changes to make Rails not required #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These changes look good to me. @anfleene, any feedback before I merge this? |
|
Looks good. I always forget mattr_accessor and cattr_accessor are in activesupport 😕 |
pbyrne
added a commit
that referenced
this pull request
Feb 19, 2016
Changes to make Rails not required
|
Merged and shipped as v1.6.6. Good luck and godspeed getting |
|
Great, thanks guys! I've got my first pass up here: https://github.com/bellycard/okcomputer-grape The README still needs some love, but I'll take care of that this weekend. |
|
Awesome. I've linked to it in our README with 22989b0. Thanks for contributing, and feel free to submit PRs if there are other areas to make this integration easier. |
|
Thanks @pbyrne! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the follow up to this discussion: #83. This should be all the changes required to make this work with my new
okcomputer-grapegem. I'm going to close the original PR in favor of this one. Let me know if you see any issues with this approach.