Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding stop instance command #136

Merged
merged 4 commits into from
Jan 31, 2018
Merged

adding stop instance command #136

merged 4 commits into from
Jan 31, 2018

Conversation

areynd
Copy link
Contributor

@areynd areynd commented Jan 31, 2018

What

Adding stop instance command

Why

To make AWS/life easier

Deploy Plan

Does Platform Operations need to know anything special about this deploy? Are migrations present?

Rollback Plan

  • To roll back this change, revert the merge with: git revert -m 1 MERGE_SHA and perform another deploy.

URLs

Links to bug tickets or user stories.

QA Plan

Reference commonly used Regression test plans on the QA Wiki
Fill in scenarios below in checklist format.
Consider Regression scenarios (did we break something else related to this change) in addition to Happy Path (testing the new feature directly).
Evaluate the risk level and label accordingly and ensure the QA Plan matches the risk level!

  • Example scenario

@@ -13,4 +13,5 @@
require "opsicle/commands/user_profile_info"
require "opsicle/commands/legacy_credential_converter"
require "opsicle/commands/failure_log"
require "opsicle/commands/stop_instance"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetize this


def stoppable_instances
@stack.stoppable_instances

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get rid of this random space

@production-status-check
Copy link

:octocat: Has QA approval

@areynd areynd merged commit 2a38809 into master Jan 31, 2018
@emmahsax emmahsax deleted the adding-stop-instance-command branch April 5, 2018 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants