Fixes for several parsing bugs #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test case will make the tests appear to hang. If let to run long enough, the test should actually pass. I didn't see a way using elm-test to set a timeout on a test and ensure that the test case finishes within that timeout. In extractPath, the URL authority (aka host as called by Erl) is used directly in the regex, without escaping, to match against itself for removal. The host part is untrusted user-input and shouldn't be used as a regular expression itself. A fix is in the next commit.
The return value from extractHost should be used literally, not as a pattern. Escape any regex metachars it contains.
The string "//" may appear anywhere in the URL, not just immediately before the authority (host). I've tried to cover several similar cases, but there may still be edge cases I missed.
We can only assume that the URL authority (host) immediately follows "//" when it's at the beginning of the URL (i.e. in a scheme-less URL). Furthermore, when using "//" or "://" as a delimiter, we want the right-hand part from the *left-most* occurrence of the delimiter, not the right-most occurrence.
|
Thanks, I will have a look soon |
|
Thanks |
|
Thanks for merging this back in June. Can you release 13.0.1 so that it's usable in projects? The latest on elm-package.org is 13.0.0. |
|
Thought I did, thanks for reminding me. Done now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including a source of runtime errors and denial-of-service via user-controlled regexes.
See the commit messages for more details.