Handle trailing slashes in parse and toString #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -322,6 +327,7 @@ parse str = | |||
| hash = (hashFromAll str), | |||
| password = "", | |||
| path = (pathFromAll str), | |||
| hasTrailingSlash = (hasTrailingSlashFromAll str), | |||
There was a problem hiding this comment.
I'm extracting the path twice here, but I thought I'd ask if that's an optimization you actually wanted before I went making bigger changes.
There was a problem hiding this comment.
I don't think this is an issue at all, it will be quite fast
|
Thanks for this, will add a couple more test and publish |
sporto
pushed a commit
that referenced
this pull request
Feb 24, 2016
Handle trailing slashes in parse and toString
|
Published v 9.0 |
|
Awesome. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds handling for trailing slashes. For documentation: we opted for
hasTrailingSlashover simply keeping""in path segments because a lot of unexpected things can come up once you start working path segments that contain"".