Don't overwrite allowed tags when allowing video embeds on Story

spot-us · Mar 16, 2009 · 3529eed · 3529eed
1 parent 4fba764
commit 3529eed
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/app/models/story.rb b/app/models/story.rb
@@ -40,8 +40,8 @@
 
 class Story < NewsItem
   cleanse_columns(:extended_description) do |sanitizer|
-    sanitizer.allowed_tags.replace(%w(object param embed a img))
-    sanitizer.allowed_attributes.replace(%w(width height name src value allowFullScreen type href allowScriptAccess style wmode pluginspage classid codebase data quality))
+    sanitizer.allowed_tags.add(%w(object param embed a img))
+    sanitizer.allowed_attributes.add(%w(width height name src value allowFullScreen type href allowScriptAccess style wmode pluginspage classid codebase data quality))
   end
 
   aasm_initial_state  :draft

diff --git a/spec/models/story_spec.rb b/spec/models/story_spec.rb
@@ -13,6 +13,14 @@
     end
   end
 
+  describe "validation" do
+    it "should allow p tags in extended description" do
+      story = Factory(:story)
+      story.extended_description = "<p>Some html</p>"
+      story.save
+      story.extended_description.should include("<p>")
+    end
+  end
   describe "status" do
     before(:each) do
       @story = Factory(:story)