Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throws exception instead of skipping already downloaded song. #1358

Closed
chasep255 opened this issue Jul 30, 2021 · 1 comment
Closed

Throws exception instead of skipping already downloaded song. #1358

chasep255 opened this issue Jul 30, 2021 · 1 comment
Labels
Bug Unexpected problem or unintended behavior that needs to be fixed

Comments

@chasep255
Copy link

System OS

Linux

Python Version

3.8 (CPython)

Install Source

pip / PyPi

Install version / commit hash

v3.7.0

Expected Behavior vs Actual Behavior

I would normally expect it to skip songs which already exist in the current directory. Instead it throws an exception.

Steps to reproduce

Download a song.
https://open.spotify.com/album/1OEGfToF7QbjUgyxMAnGXg?highlight=spotify:track:6Xe9wT5xeZETPwtaP2ynUz

Then try to download the same song again.
https://open.spotify.com/album/1OEGfToF7QbjUgyxMAnGXg?highlight=spotify:track:6Xe9wT5xeZETPwtaP2ynUz

Traceback

spotdl https://open.spotify.com/album/1OEGfToF7QbjUgyxMAnGXg?highlight=spotify:track:6Xe9wT5xeZETPwtaP2ynUz
Fetching Song...
Gathering Spotify Metadata for: 
https://open.spotify.com/album/1OEGfToF7QbjUgyxMAnGXg?highlight=spotify:track:6Xe9wT5xeZETPwtaP2ynUz
Skipping "Avicii - Levels - Original Version" as it's already downloaded

Traceback (most recent call last):
  File "/usr/local/bin/spotdl", line 8, in <module>
    sys.exit(console_entry_point())
  File "/usr/local/lib/python3.8/dist-packages/spotdl/console/__init__.py", line 81, in console_entry_point
    song_list = parse_query(
  File "/usr/local/lib/python3.8/dist-packages/spotdl/parsers/query_parser.py", line 23, in parse_query
    parse_request(request, format, use_youtube, generate_m3u, threads)
  File "/usr/local/lib/python3.8/dist-packages/spotdl/parsers/query_parser.py", line 59, in parse_request
    song = song_gatherer.from_spotify_url(request, output_format, use_youtube)
  File "/usr/local/lib/python3.8/dist-packages/spotdl/search/song_gatherer.py", line 63, in from_spotify_url
    raise OSError(f"{converted_file_name} already downloaded")
OSError: Avicii - Levels - Original Version already downloaded

Other details

No response

@chasep255 chasep255 added the Bug Unexpected problem or unintended behavior that needs to be fixed label Jul 30, 2021
@xnetcat
Copy link
Member

xnetcat commented Jul 30, 2021

update to v3.7.1

@xnetcat xnetcat closed this as completed Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Unexpected problem or unintended behavior that needs to be fixed
Projects
None yet
Development

No branches or pull requests

2 participants