Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Song cannot be found in Youtube Music despite being there #970

Closed
RowanSkie opened this issue Nov 6, 2020 · 14 comments
Closed

Song cannot be found in Youtube Music despite being there #970

RowanSkie opened this issue Nov 6, 2020 · 14 comments
Labels
Bug Unexpected problem or unintended behavior that needs to be fixed Stale Issue with no activity for the last 30 days

Comments

@RowanSkie
Copy link

So, I was trying something, and it cannot download it. The song is chumachechaya vesna/Чумачечая Весна by Potap & Nastya

Song Link:
https://open.spotify.com/track/2eaSMmKfigsm96aTUJMoIk?si=58gxM__LRneWACTrEqAPCQ

However, when you search at Youtube Music, it's first in the search:
https://music.youtube.com/search?q=%D1%87%D1%83%D0%BC%D0%B0%D1%87%D0%B5%D1%87%D0%B0%D1%8F+%D0%B2%D0%B5%D1%81%D0%BD%D0%B0

Possible error with non-Latin language when searching?

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.89. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the Bug Unexpected problem or unintended behavior that needs to be fixed label Nov 6, 2020
@RowanSkie
Copy link
Author

RowanSkie commented Nov 6, 2020

So, I downloaded its album, and it only found one song and only that song (song 26). What does that mean then?

@ghost
Copy link

ghost commented Nov 7, 2020

There is an extra layer of filtering done on results without which you'd end up with songs like 'garet swank - madness' when you try to download 'ruelle - madness'.

The other results probably get filtered out.

Under spotdl.search.providers, try changing the cutoff to a lower value. Tell me if it works.

@RowanSkie
Copy link
Author

Where can I find it?

@ghost
Copy link

ghost commented Nov 7, 2020

you can find it in spotdl/search/providers.py

@ghost
Copy link

ghost commented Nov 9, 2020

Any improvement?

@RowanSkie
Copy link
Author

I'm not really sure which variable should I change, and also all there was in provider.py, not providers.py..

@ghost
Copy link

ghost commented Nov 9, 2020

Wait, the code isn't self explanatory enough?

Don't get me wrong, we wrote that code to be readable and understandable if it isn't we clearly failed and that bit of code needs a rewrite.

@RowanSkie
Copy link
Author

A little bit, I don't know which cutoff value, since there's a lot of integer variables here.

It's either the artistMatchNumber variable or the albumMatch variable, or avgMatch variable, somewhere within the Search Provider block, I think.

@stale
Copy link

stale bot commented Dec 9, 2020

This issue has been automatically marked stale because there hasn't been any activity for the last 30 days.

@stale stale bot added the Stale Issue with no activity for the last 30 days label Dec 9, 2020
@RowanSkie
Copy link
Author

Hi, can I have which specific variable I really should check?

@stale stale bot removed the Stale Issue with no activity for the last 30 days label Dec 9, 2020
@ghost
Copy link

ghost commented Dec 9, 2020

I think its avgMatchValue.

[Update]
See search/provider.py ln:457

[Update 2]
Ignore the cutoff. See #1018.

@stale
Copy link

stale bot commented Jan 8, 2021

This issue has been automatically marked stale because there hasn't been any activity for the last 30 days.

@stale stale bot added the Stale Issue with no activity for the last 30 days label Jan 8, 2021
@RowanSkie
Copy link
Author

Well, it does work now, although it's finding some odd rock version of it. More details in #1089.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Unexpected problem or unintended behavior that needs to be fixed Stale Issue with no activity for the last 30 days
Projects
None yet
Development

No branches or pull requests

1 participant