Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update clusterrole template to be compatible with openshift #329

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

chlins
Copy link
Contributor

@chlins chlins commented Oct 19, 2021

Signed-off-by: chlins chenyuzh@vmware.com

Fixes #98

Changes proposed on the PR:

  • add persistentvolumeclaims/finalizers to role resources
  • manifest yaml under examples folder was out of date, sync with charts

Signed-off-by: chlins <chenyuzh@vmware.com>
@chlins chlins requested a review from ese as a code owner October 19, 2021 05:43
Copy link
Collaborator

@cndoit18 cndoit18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ese ese merged commit 22832cf into spotahome:master Oct 29, 2021
@maleka12
Copy link

maleka12 commented Apr 5, 2022

Hi,
we have installed redis-operator on Openshift v4.8.35 and still facing problems with error:
FailedCreate statefulset/rfr-redisfailover create Pod rfr-redisfailover-0 in StatefulSet rfr-redisfailover failed error: failed to create PVC pvcc-rfr-redisfailover-0: persistentvolumeclaims "pvcc-rfr-redisfailover-0" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: ,

Our clusterrole looks like:

kind: ClusterRole
metadata:
  name: redisoperator
rules:
- apiGroups:
  - databases.spotahome.com
  resources:
  - redisfailovers
  - redisfailovers/finalizers
  - persistentvolumeclaims
  - persistentvolumeclaims/finalizers
  - statefulsets/finalizers
  verbs:
  - '*'
- apiGroups:
  - apiextensions.k8s.io
  resources:
  - customresourcedefinitions
  verbs:
  - '*'
- apiGroups:
  - ""
  resources:
  - pods
  - services
  - endpoints
  - events
  - configmaps
  - secrets
  - persistentvolumeclaims
  - persistentvolumeclaims/finalizers
  verbs:
  - '*'
- apiGroups:
  - apps
  resources:
  - deployments
  - statefulsets
  verbs:
  - '*'
- apiGroups:
  - policy
  resources:
  - poddisruptionbudgets
  verbs:
  - '*'

Is there anyone who have installed redis-operator on openshift 4.8 and it works correctly with storage?
Maybe this occurs only on our openshift cluster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers
4 participants