Skip to content
This repository has been archived by the owner on Oct 22, 2023. It is now read-only.

Release 3.1.2 ? #32

Closed
lqc opened this issue Feb 12, 2018 · 10 comments
Closed

Release 3.1.2 ? #32

lqc opened this issue Feb 12, 2018 · 10 comments

Comments

@lqc
Copy link

lqc commented Feb 12, 2018

Hi,

I suspect that the issue with @CanIgnoreReturnValue and Guava is troublesome for many users. Maybe it would be worth doing a maintenance release ?

PS. The Sonatype repository has snapshots for 4.0.0 (which is great), but not for 3.1.x versions.

@iloveeclipse
Copy link
Member

It would make sense first to finish review of the PR spotbugs/spotbugs#529, which seem to be more or less done. @KengoTODA : I'm right, or is there anything else to do?

After the (hopefully merged) PR above I think we could create 3.1.2. I think the changes we made on 3.1.x are relatively safe. I hoped to spend some time on (internal) testing of the 3.1.x branch, but other higher prio tasks need my attention.

@KengoTODA
Copy link
Member

Let me check that PR first.

KengoTODA added a commit to KengoTODA/spotbugs that referenced this issue Feb 23, 2018
@KengoTODA
Copy link
Member

@iloveeclipse could you check spotbugs/spotbugs#564 and spotbugs/spotbugs#565? If we can merge spotbugs/spotbugs#564 first, then it's better.

@iloveeclipse
Copy link
Member

I need some time because I've moved my main system to another PC but I will try to review all PR's this weekend.

iloveeclipse pushed a commit to spotbugs/spotbugs that referenced this issue Feb 24, 2018
@iloveeclipse
Copy link
Member

So I've tried to release but failed with travis permissions error, see https://travis-ci.org/spotbugs/spotbugs/jobs/345683682. :-(

@KengoTODA
Copy link
Member

rsync: change_dir "/home/travis/build/spotbugs/spotbugs/home/travis/build/spotbugs/spotbugs/eclipsePlugin/build/site/eclipse-candidate" failed: No such file or directory (2)

I think this is not permission error, maybe we need 6f80b4b7254201fac7256fb8b579f216c892ad70 even in release-3.1 branch.

@KengoTODA
Copy link
Member

I've proposed spotbugs/spotbugs#569 again, please check @iloveeclipse.

@iloveeclipse
Copy link
Member

Many thanks. 3.1.2 is released now.

@vorburger
Copy link

@KengoTODA @iloveeclipse thanks! FYI anyone else looking for it, found release notes here:

https://github.com/spotbugs/spotbugs/blob/release-3.1/CHANGELOG.md#312---2018-02-24

@iloveeclipse
Copy link
Member

A better link is https://github.com/spotbugs/spotbugs/blob/3.1.2/CHANGELOG.md.

You can reach it via https://github.com/spotbugs/spotbugs -> click on "releases" -> in "SpotBugs 3.1.2 / Changelog" is the link.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants