Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade SpotBugs to 4.8.4 #1001

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Conversation

gtoison
Copy link
Contributor

@gtoison gtoison commented Apr 8, 2024

No description provided.

@gtoison
Copy link
Contributor Author

gtoison commented Apr 8, 2024

I would need to investigate why the unknown category count needs to be increased

@gtoison gtoison self-assigned this Apr 8, 2024
@hazendaz
Copy link
Member

I would need to investigate why the unknown category count needs to be increased

I didn't merge for that reason, assume you will merge when you are ready.

@gtoison
Copy link
Contributor Author

gtoison commented Apr 15, 2024

I was a bit confused by the names of the test referring to "unknown categories", because there was a recent issue where a new bug pattern did not have a valid category.
Some of the tests in FindbugsProfileImporterTest import a profile containing all bugs from the CORRECTNESS category. Since 4.8.4 has new bugs in that category the rules count needs to be updated, so it's all good

@gtoison gtoison merged commit b3b75d8 into spotbugs:master Apr 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants