Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix html descriptions #332

Merged
merged 5 commits into from
Nov 28, 2020

Conversation

koseduhemak
Copy link
Contributor

Fixed invalid html (missing closing tags) in rules description.

@koseduhemak koseduhemak changed the title Koseduhemak fix descriptions Fix html descriptions Oct 26, 2020
@koseduhemak
Copy link
Contributor Author

@KengoTODA: Would it be possible to take a look at or merge the changes?
We need the description in a proper format as we want to display it inside a html page.

My changes do not cover the whole faulty descriptions yet, but I will continue fixing if I get some response to this issue.

Thank you!

Copy link
Member

@KengoTODA KengoTODA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is OK to merge this PR, however, these files are generated from message.xml in fb-contrib, so coming release will overwrite this change.

Please consider to submit PR to fb-contrib project too.

@KengoTODA
Copy link
Member

#336 will update the XML files, so I will merge this PR after we merge #336 to the main branch.

@koseduhemak
Copy link
Contributor Author

Thank you.
I will also try to file a pull request in the source project, so we do not lose the fixes in future versions.

@KengoTODA
Copy link
Member

Hi @koseduhemak, could you merge origin/master to your topic branch, and resolve the conflict?
We updated the findsecbugs so XML generated based on it needs to be updated.

@mrotrebor
Copy link

Hi @KengoTODA . Do you have an estimation when the release with new version will be available? Thanks in advance.

@KengoTODA KengoTODA merged commit 370d52d into spotbugs:master Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants