Skip to content

Commit

Permalink
Merge pull request #664 from hazendaz/master
Browse files Browse the repository at this point in the history
Build updates and add analysis properties example to readme
  • Loading branch information
hazendaz committed Nov 7, 2023
2 parents fd16c1e + 0979cc5 commit 6fce414
Show file tree
Hide file tree
Showing 4 changed files with 1,007 additions and 983 deletions.
11 changes: 6 additions & 5 deletions .github/workflows/ci.yaml
@@ -1,24 +1,25 @@
name: Java CI

on: [push, pull_request]
on: [workflow_dispatch, push, pull_request]

jobs:
test:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-latest, macOS-latest, windows-latest]
java: [11, 17, 21]
os: [ubuntu-latest, macos-latest, windows-latest]
java: [11, 17, 21, 22-ea]
distribution: ['temurin']
fail-fast: false
max-parallel: 4
name: Test JDK ${{ matrix.java }}, ${{ matrix.os }}

steps:
- uses: actions/checkout@v4
- name: Set up JDK
- name: Set up JDK ${{ matrix.java }} ${{ matrix.distribution }}
uses: actions/setup-java@v3
with:
java-version: ${{ matrix.java }}
distribution: 'zulu'
distribution: ${{ matrix.distribution }}
- name: Test with Maven
run: ./mvnw test -B -V --no-transfer-progress -D"license.skip=true"
2 changes: 1 addition & 1 deletion .github/workflows/sonatype.yaml
Expand Up @@ -15,7 +15,7 @@ jobs:
uses: actions/setup-java@v3
with:
java-version: 21
distribution: 'zulu'
distribution: zulu
- name: Deploy to Sonatype
run: ./mvnw deploy -DskipTests -B -V --no-transfer-progress --settings ./.mvn/settings.xml -Dlicense.skip=true
env:
Expand Down
18 changes: 18 additions & 0 deletions README.md
Expand Up @@ -85,3 +85,21 @@ If using groovy with same group id (```org.codehaus.groovy 3.x``` or before or `
## Eclipse m2e Integration ##

The plugin cycles controlled by Eclipse require compilation phase for m2e without further help. This plugin runs verify and during site generation. Therefore Eclipse m2e will show up but not do anything with this plugin alone. In order to have proper execution within Ecipse m2e, use [m2e-code-quality](https://github.com/m2e-code-quality/m2e-code-quality) plugin for spotbugs.

## Analysis Properties ##

Is there some way to set the [Analysis Properties](https://spotbugs.readthedocs.io/en/stable/analysisprops.html) when using the maven plugin?

Analysis properties are passed as Java system properties, so they can be set in the <jvmArgs> configuration element.

E.g. to set the findbugs.assertionmethods analyzer property:

```
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<jvmArgs>-Dfindbugs.assertionmethods=org.apache.commons.lang3.Validate.notNull</jvmArgs>
</configuration?
</plugin>
```

0 comments on commit 6fce414

Please sign in to comment.