Add IT test to check excludeFiltersFile duplications on multi-module projects #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfn
reviewed
Dec 15, 2020
| </build> | ||
|
|
||
| <properties> | ||
| <project.parent.relativePath>..</project.parent.relativePath> |
There was a problem hiding this comment.
@aoterolorenzo If you only need to run Spotbugs in the submodules, you can move the plugin configuration in this POM to the <pluginManagement> section. After that, you wouldn't need to force a project.parent.relativePath redefinition here.
There was a problem hiding this comment.
I'm aware, that lines were and absolute playground to try out some stuff. I just saw and removed them a minute before your comment. Thank you! :)
|
@aoterolorenzo Thanks, I'm pulling this now so I can kick the tires here and see the issue locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #281
An IT test has been created to cause and detect the issue. This test checks the existence of the excludeFiltersFile provided on the parent POM in each submodule, when a
relativePathis used to declare it, taken the specific case from the info and examples provided in #281.