Add new parameter to provide SpotBugs with source paths from Maven #71
Conversation
when running detectors.
|
I'm not seeing why maven needs updated. We already tried that and the community using this plugin had lots of issues so we need to stay on 3.1.1 support for now.
Get Outlook for Android<https://aka.ms/ghei36>
…________________________________
From: Irian81 <notifications@github.com>
Sent: Wednesday, July 18, 2018 2:41:53 AM
To: spotbugs/spotbugs-maven-plugin
Cc: Subscribed
Subject: [spotbugs/spotbugs-maven-plugin] Add new parameter to provide SpotBugs with source paths from Maven (#71)
Initial PR for review to add support for full source paths on source filter (when available).
The only thing I'm not sure about in this PR is the prerequisite maven version that will not normally compile unless upped to 3.5.3, that will inhibit users from taking advantage of this plugin unless in the 3.5.3 version or upper.
This should be paired with spotbugs PR #700, as it basically enables the functionality there to be used by the maven plugin.
________________________________
You can view, comment on, or merge this pull request online at:
#71
Commit Summary
* Add new parameter to provide SpotBugs with source paths from Maven
File Changes
* M pom.xml<https://github.com/spotbugs/spotbugs-maven-plugin/pull/71/files#diff-0> (6)
* M src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy<https://github.com/spotbugs/spotbugs-maven-plugin/pull/71/files#diff-1> (20)
Patch Links:
* https://github.com/spotbugs/spotbugs-maven-plugin/pull/71.patch
* https://github.com/spotbugs/spotbugs-maven-plugin/pull/71.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#71>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AA7ho1Nhgoq8o9YfNsAZA4vjyaWdm24_ks5uHtixgaJpZM4VUB2Q>.
|
|
Sorry it was late in the night yesterday and I forgot to turn off
automatic maven home switching, so I was having build problems because
my system was automatically switching to maven 3.1.1 for building the
plugin and that is not allowed by the enforcer rules.
I've reverted the
change so everything should be fine now.
Il 18.07.2018 14:57 Jeremy
Landis ha scritto:
I'm not seeing why maven needs updated. We
already tried that and the community using this plugin had lots of
issues so we need to stay on 3.1.1 support for now.
Get Outlook for
Android
________________________________
From: Irian81
Sent:
Wednesday, July 18, 2018 2:41:53 AM
To:
spotbugs/spotbugs-maven-plugin
Cc: Subscribed
Subject:
[spotbugs/spotbugs-maven-plugin] Add new parameter to provide SpotBugs
with source paths from Maven (#71)
Initial PR for review to add
support for full source paths on source filter (when available).
The only thing I'm not sure about in this PR is the prerequisite maven
version that will not normally compile unless upped to 3.5.3, that will
inhibit users from taking advantage of this plugin unless in the 3.5.3
version or upper.
This should be paired with spotbugs PR #700, as
it basically enables the functionality there to be used by the maven
plugin.
________________________________
You can view, comment
on, or merge this pull request online at:
Commit
Summary
* Add new parameter to provide SpotBugs with source paths
from Maven
File Changes
* M pom.xml (6)
* M
src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy (20)
Patch Links:
*
*
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
--
You are receiving this because you authored the thread.
Reply
to this email directly, view it on GitHub [1], or mute the thread [2].
Con MyOpen hai Giga, SMS e i minuti che vuoi da 3€ al mese, per sempre. Cambi gratis quando e come vuoi e in più hai 10€ di credito omaggio!
SCOPRI DI PIU’ http://tisca.li/myopen
|
|
@Irian81 Thanks. I'll hang on this for a while until spot bugs is off snapshot. However, have a question, how does this improve things? Maven already knows it's source, why are we scanning outside of maven source? Seems like an incorrect maven project setup to me. |
|
The use case for this can be found in main spotbugs issue 694. The added source roots are required to let the modified source filter that is being reviewed in PR 700 work, since without this modification to the maven plugin only the target folder is known to spotbugs during the analisys phase so source exlusion based off real source paths would not work. If you want to test drive this there is an example project attached to issue 694 that with the current version of the maven plugin and spotbugs gives 4 positives, with the modified version of the maven plugin, parameter <addSourceDirs>true</addSourceDirs> and patched spotbugs source filter gives only 2 positives. |
|
@Irian81 Great work! we are also looking into this issue. Is there anything we can support you with? |
|
@PhilMFischer Merge conflicts would need resolved and I think there is still a pice not yet applied on spotbugs as the first link provided in prior commits is still open. |
|
@PhilMFischer I think your work is over on PR spotbugs/spotbugs#903 on spotbugs and needs merged before this can. I was originally referring to PR 700. |
|
@hazendaz Right, i got your point. Do we reopen this PR once the spotbugs/spotbugs#903 is sucessfully merged? |
Initial PR for review to add support for full source paths on source filter (when available).
The only thing I'm not sure about in this PR is the prerequisite maven version that will not normally compile unless upped to 3.5.3, that will inhibit users from taking advantage of this plugin unless in the 3.5.3 version or upper.
This should be paired with spotbugs PR #700, as it basically enables the functionality there to be used by the maven plugin.