Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move modernizer to 2.9.0 an dupdate readme regarding security manager #810

Merged
merged 2 commits into from
May 23, 2024
Merged

Move modernizer to 2.9.0 an dupdate readme regarding security manager #810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97bc401
[pom] Bump modernizer to 2.9.0
hazendaz May 23, 2024
0443045
[ci] Update readme for security manager
hazendaz May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ This plugin is written entirey in groovy. It does have limitations when it come

Known issues

The security manager is turned off by default in jdk 18/19 and scheduled from removal in a future java release, therefore to use this plugin with jdk 18/19, the security manager may need turned back on using ```JAVA_OPTS``` to ```-Djava.security.manager=allow```. See [groovy](https://groovy-lang.org/releasenotes/groovy-4.0.html) for more details.
The security manager is turned off by default in jdk 18 and scheduled from removal in a future java release, therefore to use this plugin with jdk 18+, the security manager may need turned back on using ```JAVA_OPTS``` to ```-Djava.security.manager=allow```. See [groovy](https://groovy-lang.org/releasenotes/groovy-4.0.html) for more details.

If using groovy with same group id (```org.codehaus.groovy 3.x``` or before or ```org.apache.groovy 4.x or above```), an error may occur if not on same version. To alleviate that, make sure groovy artifacts are defined in ```dependency management``` in order to force the loaded version correctly on your usage.

Expand Down
6 changes: 3 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,9 +248,9 @@
<!-- Automatic Module Name -->
<module.name>com.github.spotbugs.maven</module.name>

<!-- TODO: Drop modernizer back to 2.7.0 due to strict maven 3.9.5 requirement -->
<modernizer.version>2.7.0</modernizer.version>
<modernizer.plugin>2.7.0</modernizer.plugin>
<!-- TODO: Remove after base-parent 46 released -->
<modernizer.version>2.9.0</modernizer.version>
<modernizer.plugin>2.9.0</modernizer.plugin>
</properties>

<dependencyManagement>
Expand Down