Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce submodule #6

Closed
wants to merge 3 commits into from

Conversation

KengoTODA
Copy link
Member

Problem

  • We put both of source and generated files (HTML, CSS, images, etc.) to the same branch, so our diff in PR becomes really dirty

Solution in this pull request

This PR adds a build directory, which works as a Git submodule.
Later we can add more PR to delete generated files from master branch.

I also pushed gh-pages branch to this repository, which has the same content with master branch. We can use gh-pages this page to host static pages instead of master branch.

refs: https://github.com/shiftyp/submodule-gh-pages-example

@jsotuyod
Copy link
Member

jsotuyod commented Jan 2, 2017

This approach doesn't seem to be working. I introduced a change on the index of gh-pages' index.html

However, I don't see this when accessing the page at https://spotbugs.github.io/

Are we missing something? Maybe the gh-pages approach doesn't work for *.github.io repositories...

@KengoTODA
Copy link
Member Author

Oh, yes, you are right...

User and Organization Pages that have this type of repository name are only published from the master branch.
https://help.github.com/articles/configuring-a-publishing-source-for-github-pages/

Then we need to use special branch not to host site but to manage sources. I will recreate similar pull request. Thanks for your review!

@KengoTODA KengoTODA closed this Jan 2, 2017
@KengoTODA KengoTODA deleted the introduce-submodule branch January 2, 2017 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants