drop half-baked efforts to make things serializable #81 (#85)

* drop half-baked efforts to make things serializable #81 * remove obsolete serialVersionUID #81
spotbugs · Dec 12, 2016 · 6b5e6f0 · 6b5e6f0
1 parent c63935f
commit 6b5e6f0
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 19 deletions.
diff --git a/findbugs/src/gui/edu/umd/cs/findbugs/gui2/MainFrameMenu.java b/findbugs/src/gui/edu/umd/cs/findbugs/gui2/MainFrameMenu.java
@@ -11,7 +11,6 @@
 import java.awt.event.ItemListener;
 import java.awt.event.KeyEvent;
 import java.io.File;
-import java.io.Serializable;
 import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
 import java.util.ArrayList;
@@ -38,7 +37,7 @@
 import edu.umd.cs.findbugs.gui.AnnotatedString;
 import edu.umd.cs.findbugs.gui2.FilterListener.Action;
 
-public class MainFrameMenu implements Serializable {
+public class MainFrameMenu {
     private final MainFrame mainFrame;
 
     JMenuItem reconfigMenuItem = newJMenuItem("menu.reconfig", "Reconfigure...", KeyEvent.VK_F);

diff --git a/findbugs/src/gui/edu/umd/cs/findbugs/gui2/MainFrameTree.java b/findbugs/src/gui/edu/umd/cs/findbugs/gui2/MainFrameTree.java
@@ -14,7 +14,6 @@
 import java.awt.event.MouseAdapter;
 import java.awt.event.MouseEvent;
 import java.awt.event.MouseListener;
-import java.io.Serializable;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collections;
@@ -49,7 +48,7 @@
 import edu.umd.cs.findbugs.filter.Matcher;
 import edu.umd.cs.findbugs.gui2.FilterActivity.FilterActivityNotifier;
 
-public class MainFrameTree implements Serializable {
+public class MainFrameTree {
     private final MainFrame mainFrame;
 
     JTree tree;

diff --git a/findbugs/src/main/java/edu/umd/cs/findbugs/BugInstance.java b/findbugs/src/main/java/edu/umd/cs/findbugs/BugInstance.java
@@ -22,7 +22,6 @@
 import static java.util.Objects.requireNonNull;
 
 import java.io.IOException;
-import java.io.Serializable;
 import java.io.UnsupportedEncodingException;
 import java.math.BigInteger;
 import java.security.MessageDigest;
@@ -110,9 +109,7 @@
  * @author David Hovemeyer
  * @see BugAnnotation
  */
-public class BugInstance implements Comparable<BugInstance>, XMLWriteable, Serializable, Cloneable {
-
-    private static final long serialVersionUID = 1L;
+public class BugInstance implements Comparable<BugInstance>, XMLWriteable, Cloneable {
 
     private final String type;
 

diff --git a/findbugs/src/main/java/edu/umd/cs/findbugs/ba/type/ExceptionSet.java b/findbugs/src/main/java/edu/umd/cs/findbugs/ba/type/ExceptionSet.java
@@ -19,7 +19,6 @@
 
 package edu.umd.cs.findbugs.ba.type;
 
-import java.io.Serializable;
 import java.util.BitSet;
 import java.util.Iterator;
 import java.util.NoSuchElementException;
@@ -42,8 +41,7 @@
  * @author David Hovemeyer
  * @see TypeAnalysis
  */
-public class ExceptionSet implements Serializable {
-    private static final long serialVersionUID = 1;
+public class ExceptionSet {
 
     private final ExceptionSetFactory factory;
 

diff --git a/findbugs/src/main/java/edu/umd/cs/findbugs/ba/type/ExceptionSetFactory.java b/findbugs/src/main/java/edu/umd/cs/findbugs/ba/type/ExceptionSetFactory.java
@@ -19,17 +19,12 @@
 
 package edu.umd.cs.findbugs.ba.type;
 
-import java.io.Serializable;
 import java.util.ArrayList;
 import java.util.HashMap;
 
 import org.apache.bcel.generic.ObjectType;
 
-public class ExceptionSetFactory implements Serializable {
-    /**
-     *
-     */
-    private static final long serialVersionUID = 1L;
+public class ExceptionSetFactory {
 
     private final HashMap<ObjectType, Integer> typeIndexMap;
 

diff --git a/findbugs/src/main/java/edu/umd/cs/findbugs/log/Profiler.java b/findbugs/src/main/java/edu/umd/cs/findbugs/log/Profiler.java
@@ -21,7 +21,6 @@
 
 import java.io.IOException;
 import java.io.PrintStream;
-import java.io.Serializable;
 import java.util.Comparator;
 import java.util.EmptyStackException;
 import java.util.Stack;
@@ -276,7 +275,7 @@ public void end(Class<?> c) {
 
     }
 
-    public static class ClassNameComparator implements Comparator<Class<?>>, Serializable {
+    public static class ClassNameComparator implements Comparator<Class<?>> {
         final protected Profiler profiler;
 
         public ClassNameComparator(Profiler p) {