Skip to content

Commit

Permalink
Bumped jaxen from 1.1.6 to 1.2.0 version
Browse files Browse the repository at this point in the history
This fixes issue #1316 and finally fixes issue #1315.

This change switches from Jaxen 1.1.6 to 1.2.0 to allow compilation of
the projects that rely on SpotBugs project with Java 11.

Jaxen is a transitive optional dependency of dom4j that we use in
SpotBugs.

Jaxen 1.1.6 ships org.w3c.dom package, which is also now shipped by JDK
in java.xml module. Java 9+ comiler disallow compilation if modules on
module path ship same package. So compilation of spotbugsTestCases with
Java 11 fails if the target release is 11 with the error: "The package
org.w3c.dom is accessible from more than one module: <unnamed>,
java.xml".

Solution is to update Jaxen to 1.2.0 version, that does not ship
org.w3c.dom package anymore.

Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
  • Loading branch information
iloveeclipse committed Sep 29, 2020
1 parent 209c4ac commit c23d43a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Currently the versioning policy of this project follows [Semantic Versioning v2.

## Unreleased - 2020-??-??
### Changed
* Bump jaxen from 1.1.6 to 1.2.0 supporting Java 11 compilation ([#1316](https://github.com/spotbugs/spotbugs/issues/1316))
* Bump ASM from 8.0.1 to 9.0 supporting JDK16 (sealed classes)

## 4.1.3 - 2020-09-25
Expand Down
6 changes: 3 additions & 3 deletions spotbugs/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ dependencies {
exclude group: 'pull-parser', module: 'pull-parser'
exclude group: 'xpp3', module: 'xpp3'
}
implementation 'jaxen:jaxen:1.1.6' // only transitive through dom4j:dom4j:1.6.1, which has an *optional* dependency on jaxen:jaxen.
implementation 'jaxen:jaxen:1.2.0' // only transitive through dom4j:dom4j:1.6.1, which has an *optional* dependency on jaxen:jaxen.
api 'org.apache.commons:commons-lang3:3.11'
api 'org.apache.commons:commons-text:1.9'
api 'org.slf4j:slf4j-api:1.8.0-beta4'
Expand All @@ -104,7 +104,7 @@ dependencies {
guiTestImplementation sourceSets.gui.runtimeClasspath
guiTestImplementation 'junit:junit:4.13'
guiTestCompileOnly project(':spotbugs-annotations')

// for Eclipse compilation only
appleExtensions 'com.apple:AppleJavaExtensions:1.4'
}
Expand Down Expand Up @@ -361,4 +361,4 @@ spotbugsTest {
// TODO : validatesamplexmloutput

// XML validation
// TODO : validate
// TODO : validate

0 comments on commit c23d43a

Please sign in to comment.