-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem found when integrating with SonarQube #136
Comments
@MichaelHai firstly, let me thank you in name of the SpotBugs team for helping us test our release candidate for 3.1.0. @h3xstream this seems like something you should handle, being the maintainer of that plugin. At first sight, I'm not sure what synthetic you are looking for on that report that we may be missing in SpotBugs. |
This is an old test case.. I am not sure what synthetic bug instances are. |
I've investigated about this, it seems that we can handle it as expected behaviour change. According to FindBugs 3.0.1 reported name of anonymous class (e.g. In 3.0.1
3.1.0-RC1
|
This change makes sonar-findbugs depending on SpotBugs 3.1.0-RC1 which does not support Java7. See changelog for detailed difference: https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md#310-rc1-2017feb21 Note that this change is based on MichaelHai's change which is proposed at: spotbugs/spotbugs#136
I've proposed a PR for SonarQubeCommunity, to share how to replace FindBugs with SpotBugs. |
@KengoTODA amazing work. Good to see it wasn't a change we introduced, I couldn't recall anything that could have produced such a change. I agree the new way to report it is much more intuitive, I'm ok with just changing the test on Sonar's side. |
Did any new rules were added between FindBugs 3.0.1 and SpotBugs 3.1.0-RC1 ? I ran a diff and their is only description changes. |
No rules were added. Please refer https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md#added |
I tried to integrate SpotBugs with SonarQube by simply change the dependence in sonar-findbugs-plugin from FindBugs to SpotBugs (and change the fb-contrib version for compatibiliy).
The plugin with the modification works well when I use it to analysis a project and several new issues related to lambda expression were found.
However, during the build process, this assertion failed so I have to comment it out. It checks the xml report generated by FindBugs(SpotBugs).
This is what I did: spotbugs/sonar-findbugs@master...MichaelHai:change-to-spotbugs
The text was updated successfully, but these errors were encountered: