Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All command line scripts are broken #323

Closed
iloveeclipse opened this issue Aug 17, 2017 · 2 comments
Closed

All command line scripts are broken #323

iloveeclipse opened this issue Aug 17, 2017 · 2 comments
Assignees
Labels

Comments

@iloveeclipse
Copy link
Member

After commit 8b518ec all command line scripts do not forward arguments, so all command line tasks work now without any arguments. This is a blocker.

They all should append $@ at the end of the new command line to forward arguments to fbwrap script.

@sewe
Copy link

sewe commented Aug 17, 2017

Sorry about that. I’ll fix this ASAP.

sewe pushed a commit to sewe/spotbugs that referenced this issue Aug 17, 2017
In addition to now correctly passing on argument lists, this
change also further improves upon the scripts; they now "exec"
the script they warp, thus saving an extra process. Also, a few
scripts which are effectively synonyms of another script
(unionBugs/unionResults and updateBugs/computeBugHistory) now
"exec" canonical scripts.
@sewe sewe added the bug label Aug 17, 2017
iloveeclipse pushed a commit that referenced this issue Aug 18, 2017
In addition to now correctly passing on argument lists, this
change also further improves upon the scripts; they now "exec"
the script they warp, thus saving an extra process. Also, a few
scripts which are effectively synonyms of another script
(unionBugs/unionResults and updateBugs/computeBugHistory) now
"exec" canonical scripts.
@iloveeclipse
Copy link
Member Author

Closed via #324.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants