Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Spotbugs Eclipse Preferences in userPrefs #728

Closed
dlwildschut opened this issue Aug 9, 2018 · 2 comments
Closed

Support Spotbugs Eclipse Preferences in userPrefs #728

dlwildschut opened this issue Aug 9, 2018 · 2 comments

Comments

@dlwildschut
Copy link
Contributor

The -userPrefs option for Spotbugs doesn't parse the .epf Preferences produced by the SpotBugs Eclipse Plugin.
The SpotBugs plugin preferences contain the prefix /instance/com.github.spotbugs.plugin.eclipse/, which is not removed in the edu.umd.cs.findbugs.config.UserPreferences.read(@WillClose InputStream in) method.
Please remove the prefix, which is already being done with /instance/edu.umd.cs.findbugs.plugin.eclipse/ from the Preferences produced by the old FindBugs Eclipse plugin.
@iloveeclipse
Copy link
Member

Do you want to contribute a patch?

dlwildschut added a commit to ABM-GmbH/spotbugs that referenced this issue Aug 10, 2018
@dlwildschut
Added support for User Preferences exported from SpotBugs Eclipse Plu…
9a0db8e 
…gin, fixes spotbugs#728
@dlwildschut dlwildschut mentioned this issue Aug 10, 2018
Merged
1 task
@dlwildschut
Copy link
Contributor Author

I created a pull request #729, could you please review my changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iloveeclipse @dlwildschut