Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android annotation support? #96

Closed
GeekMin opened this issue Dec 26, 2016 · 1 comment
Closed

android annotation support? #96

GeekMin opened this issue Dec 26, 2016 · 1 comment

Comments

@GeekMin
Copy link

GeekMin commented Dec 26, 2016

As I know:
Findbugs has added support for these annotations:
@com.google.common.base.Nullable
@org.jetbrains.annotations.Nullable
@org.jetbrains.annotations.NotNull
@org.eclipse.jdt.annotation.Nullable
@org.eclipse.jdt.annotation.NonNull
@org.eclipse.jdt.annotation.NonNullByDefault
+
JSR305

but android-related:
android.support.annotation.NonNull;
android.support.annotation.Nullable;

is not supported-yet?

If I want to add support for android annotation, how can I do?

@jsotuyod
Copy link
Member

Android support is in our backlog, but we will probably not address it for 3.1.0. However, you are free to submit a PR. Fortunately for you, doing so shouldbe relatively easy. You could check this PR originally submitted for Findbugs (never merged) findbugsproject/findbugs#117

With that in place, you can write a proper integration test using our new testing framework. You can check how to write a sample class to be analyzed and then write an integration test

With that you can submit a PR and we will gladly look into it and merge it.

@jsotuyod jsotuyod added this to the SpotBugs 4.0.0 milestone Jan 2, 2017
KengoTODA pushed a commit that referenced this issue Jun 7, 2017
* Add tests for NullnessAnnotation.Parser
* Add android annotations to Nullness detector
* Add android nullness annotation to the resolver, add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants