Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete jar files in findbugs/lib directory #109

Merged
merged 2 commits into from
Jan 26, 2017
Merged

Delete jar files in findbugs/lib directory #109

merged 2 commits into from
Jan 26, 2017

Conversation

KengoTODA
Copy link
Member

Almost same with #104, but this pull request does not delete jar files in findbugsTestCases because these files are necessary for AbstractIntegrationTest class in :test-harness project.

This change is necessary to generate pom.xml which contains proper <dependency> elements.

@KengoTODA KengoTODA self-assigned this Jan 26, 2017
@KengoTODA KengoTODA mentioned this pull request Jan 26, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 56.728% when pulling ee41cf2 on KengoTODA:delete-jar-file into 4c6c6c5 on spotbugs:master.

@henrik242
Copy link
Contributor

@KengoTODA Just a hint: You could have just force pushed onto the same branch as in the #104, and the PR would have updated accordingly.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 56.728% when pulling ee41cf2 on KengoTODA:delete-jar-file into 4c6c6c5 on spotbugs:master.

henrik242
henrik242 approved these changes Jan 26, 2017
View reviewed changes
Copy link
Contributor

@henrik242 henrik242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KengoTODA
Copy link
Member Author

@henrik242 OK I will reuse PR from next.

@henrik242 henrik242 merged commit 0f40e3e into spotbugs:master Jan 26, 2017
@KengoTODA KengoTODA deleted the delete-jar-file branch January 26, 2017 14:15
@KengoTODA KengoTODA modified the milestone: SpotBugs 3.1.0 Jan 26, 2017
@KengoTODA KengoTODA mentioned this pull request Feb 1, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrik242 henrik242 henrik242 approved these changes

Assignees

@KengoTODA KengoTODA

Labels
enhancement
Projects
None yet
Milestone
SpotBugs 3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KengoTODA @coveralls @henrik242