Make test harness portable #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this AbstractIntegrationTest contains several hard-coded path which depends on structure of spotbugs project. To let plugin developers code without limitation like this, it is better to move this Test class to findbugs/src/test.
jsotuyod
reviewed
Feb 3, 2017
| @@ -0,0 +1,81 @@ | |||
| package edu.umd.cs.findbugs; | |||
There was a problem hiding this comment.
we should probably move this to a more appropriate package... maybe edu.umd.cs.findbugs.test?
| @@ -0,0 +1,40 @@ | |||
| package edu.umd.cs.findbugs; | |||
| @@ -0,0 +1,118 @@ | |||
| package edu.umd.cs.findbugs; | |||
jsotuyod
approved these changes
Feb 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
AbstractIntegrationTestintest-harnesshas several hard-coded value which depends on project structure of this repository, such as"../findbugsTestCases","lib"and"/build/classes/main/". To make this library portable, it's better to remove them.And one more problem, is that, we provide utilities as abstract class so it might be hard to use with another solution which uses the same way. Basically
Ruleis better choice for JUnit.This pull request proposes:
CountMatcherAnalysisRunnerExternalResourcenamedSpotBugsRuleAbstractIntegrationTesttofindbugssubprojectSpotBugsRuleinFindUnsatisfiedObligationTest