Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #123 - restore Version.RELEASE #125

Merged
merged 2 commits into from
Feb 15, 2017
Merged

Fixes #123 - restore Version.RELEASE #125

merged 2 commits into from
Feb 15, 2017

Conversation

jsotuyod
Copy link
Member

@jsotuyod jsotuyod commented Feb 13, 2017 •
edited
Loading

@jsotuyod
Fixes #123 - restore Version.RELEASe
1f6c0d6 
 - Mark it as deprecated
 - On next version it should be removed for good.
@jsotuyod jsotuyod added this to the SpotBugs 3.1.0 milestone Feb 13, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 1f6c0d6 on issue-123 into ** on master**.

KengoTODA
KengoTODA reviewed Feb 13, 2017
View reviewed changes
Copy link
Member

@KengoTODA KengoTODA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch should fix tje 1st problem reported in #123. How about 2nd problem?

@KengoTODA
Copy link
Member

May we need to apply some solution like http://stackoverflow.com/a/1273196

@jsotuyod jsotuyod changed the title Fixes #123 - restore Version.RELEASe Fixes #123 - restore Version.RELEASE Feb 13, 2017
@jsotuyod
Copy link
Member Author

@KengoTODA sorry! I hadn't noticed the second issue.

Yes, it looks like doing that is going to be needed. Possibly adding checks to make sure we are on the correct manifest... I'll try and think about something.

@KengoTODA
Copy link
Member

Yes, thank you!

One more note: CHANGELOG.md has a place to list deplications, please add Versions.RELEASE to there.

@KengoTODA KengoTODA mentioned this pull request Feb 14, 2017
Merged
@jsotuyod
Make sure we get the proper manifest
d308e7f 
 - Iterate over manifests until we find the one we are looking for
 - Get theversion from that one
@jsotuyod
Copy link
Member Author

@KengoTODA there you go! I believe it should work now...

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d308e7f on issue-123 into ** on master**.

@KengoTODA
Copy link
Member

Great work @jsotuyod! I confirmed that:

  • version attribute in findbugsXml.xml has been filled as expected
  • site goal can generate HTML report as expected

@KengoTODA KengoTODA merged commit 389e33a into master Feb 15, 2017
@KengoTODA KengoTODA deleted the issue-123 branch February 15, 2017 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KengoTODA KengoTODA KengoTODA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
SpotBugs 3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsotuyod @coveralls @KengoTODA