Fixes issue #1313 #1337
Merged
Fixes issue #1313 #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix for issue 1313, do not report volatile problems in synthetic code With the fix for Eclipse bug 544521, https://bugs.eclipse.org/bugs/show_bug.cgi?id=544521, the Eclipse 4.17+ Java compiler will generate synthetic code for switch expressions. spotbugs reports VO_VOLATILE_REFERENCE_TO_ARRAY issues in this synthetic code. This changes makes spotbugs ignore synthetic fields during VO_VOLATILE_REFERENCE_TO_ARRAY analysis.
iloveeclipse
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for issue #1313, do not report volatile problems in synthetic code
With the fix for Eclipse bug 544521,
https://bugs.eclipse.org/bugs/show_bug.cgi?id=544521, the Eclipse 4.17+
Java compiler will generate synthetic code for switch expressions.
spotbugs reports VO_VOLATILE_REFERENCE_TO_ARRAY issues in this synthetic
code.
This changes makes spotbugs ignore synthetic fields during
VO_VOLATILE_REFERENCE_TO_ARRAY analysis.
Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code