Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic spotbugs plugin #142

Merged
merged 12 commits into from
Mar 17, 2017
Merged

basic spotbugs plugin #142

merged 12 commits into from
Mar 17, 2017

Conversation

johnscancella
Copy link
Contributor

refs #133
you would still need to sign up for a plugins.gradle.org account and configure it to upload the plugin

@johnscancella johnscancella mentioned this pull request Feb 24, 2017
@johnscancella
Copy link
Contributor Author

johnscancella commented Feb 24, 2017

Can someone explain why Travis-ci is failing(maybe @KengoTODA)? I didn't touch anything outside of the gradlePlugin directory and adding it to settings.gradle file.

@KengoTODA
Copy link
Member

I will check build log later.

settings.gradle Outdated
@@ -1,7 +1,7 @@
def eclipseFile = "eclipsePlugin/local.properties"
if (new File(eclipseFile).exists()) {
include ':spotbugsTestCases', ':spotbugs', ':eclipsePlugin', ':test-harness', ':spotbugs-annotations', ':spotbugs-ant'
include ':eclipsePlugin', ':findbugsTestCases', ':findbugs', ':gradlePlugin', ':test-harness', ':spotbugs-annotations', ':spotbugs-ant', 'gradlePlugin'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ':spotbugsTestCases', ':spotbugs' instead of ':findbugsTestCases', ':findbugs'

Recently we changed name of directories at #141 and #137.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.554% when pulling d8dbdf8 on johnscancella:master into 47a9c0e on spotbugs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.554% when pulling cd04248 on johnscancella:master into 47a9c0e on spotbugs:master.

@KengoTODA
Copy link
Member

Please update migration document too.

@johnscancella
Copy link
Contributor Author

@KengoTODA you can't really update the migration document until you have published to plugins.gradle.org since the documentation should really just be a link to the plugin on plugins.gradle.org

@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.554% when pulling 4a6e390 on johnscancella:master into 8a4c6c7 on spotbugs:master.

@KengoTODA
Copy link
Member

@johnscancella Could you introduce checkstyle like this?

And, actually I'm not sure but don't we need to publish this module onto Maven Central? We just need to upload it to plugins.gradle.org? If publishing onto Maven Central is also necessary, please consider:

  • Add javadoc & maven plugin like this
  • Put your name to <developer> element in generated pom.xml

@jsotuyod I have less experience around Gradle, could you review this?

@johnscancella
Copy link
Contributor Author

@KengoTODA no need to put it on maven central in order to use it as a gradle plugin.
I will add checkstyle and update the PR

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 57.615% when pulling 5fb8295 on johnscancella:master into 8a4c6c7 on spotbugs:master.

Copy link
Contributor

@henrik242 henrik242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shtratos
Copy link

Thank you for doing this, guys!

@henrik242 henrik242 merged commit b565c63 into spotbugs:master Mar 17, 2017
@ben-manes
Copy link

When will the gradle plugin be published?

@henrik242
Copy link
Contributor

I guess it will be released together with SpotBugs 3.1.0 (see issue #111 )

@KengoTODA KengoTODA modified the milestone: SpotBugs 3.1.0 May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants