-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basic spotbugs plugin #142
Conversation
Can someone explain why Travis-ci is failing(maybe @KengoTODA)? I didn't touch anything outside of the gradlePlugin directory and adding it to settings.gradle file. |
I will check build log later. |
settings.gradle
Outdated
@@ -1,7 +1,7 @@ | |||
def eclipseFile = "eclipsePlugin/local.properties" | |||
if (new File(eclipseFile).exists()) { | |||
include ':spotbugsTestCases', ':spotbugs', ':eclipsePlugin', ':test-harness', ':spotbugs-annotations', ':spotbugs-ant' | |||
include ':eclipsePlugin', ':findbugsTestCases', ':findbugs', ':gradlePlugin', ':test-harness', ':spotbugs-annotations', ':spotbugs-ant', 'gradlePlugin' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update migration document too. |
@KengoTODA you can't really update the migration document until you have published to plugins.gradle.org since the documentation should really just be a link to the plugin on plugins.gradle.org |
…al plugin on plugins.gradle.org
@johnscancella Could you introduce checkstyle like this? And, actually I'm not sure but don't we need to publish this module onto Maven Central? We just need to upload it to plugins.gradle.org? If publishing onto Maven Central is also necessary, please consider:
@jsotuyod I have less experience around Gradle, could you review this? |
@KengoTODA no need to put it on maven central in order to use it as a gradle plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thank you for doing this, guys! |
When will the gradle plugin be published? |
I guess it will be released together with SpotBugs 3.1.0 (see issue #111 ) |
refs #133
you would still need to sign up for a plugins.gradle.org account and configure it to upload the plugin