False positive SA_LOCAL_SELF_COMPARISON when using instanceof pattern matching #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-matching-false-positive
…github.com/schosin/spotbugs into schosin-instanceof-pattern-matching-false-positive
|
Hi @spotbugs/everyone , please review this PR when you have time. Thanks in advance! |
|
The PR references some wrong issue #1134? |
|
Good catch @iloveeclipse, it should be #1136.
Ah, I see. Actually it's problem only with Java 14. So when I switch to Java 15 in 51ae7ab, the test has been stable. |
The bug is caused by Java 14, that is outdated and not maintained any more. In the SpotBugs side we need no update, so we should have no entry in this file.
|
Kudos, SonarCloud Quality Gate passed!
|
ThrawnCA
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreated from #1136 to build with the latest change.