When AnalysisRunner has findbugs.xml in jar, don't create temp jar #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzaikin
force-pushed
the
enable-AnalysisRunner
branch
from
f434b85
to
d1e723f
Compare
kzaikin
commented
May 29, 2017
| * @return a {@link File} instance which represent generated jar file | ||
| * @throws IOException | ||
| * @throws URISyntaxException | ||
| */ | ||
| private static File createTempJar() throws IOException, URISyntaxException { | ||
| ClassLoader cl = AnalysisRunner.class.getClassLoader(); | ||
|
|
||
| URL resource = cl.getResource("findbugs.xml"); | ||
| URI uri = resource.toURI(); |
There was a problem hiding this comment.
the resource might be null here, but I think it's ok to fall with NPE in tests when test configuration is unexpected
|
@KengoTODA I am not sure what should I do to have this PR reviewed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When AnalysisRunner is using spotbugs.jar, then there's no need to create temp jar for resources
fix #156