Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Earlier/LaterSubtypes supports only built-in supertypes (#215) #223

Merged
merged 1 commit into from
Jun 28, 2017
Merged

Earlier/LaterSubtypes supports only built-in supertypes (#215) #223

merged 1 commit into from
Jun 28, 2017

Conversation

sewe
Copy link

@sewe sewe commented Jun 26, 2017

This lets the PluginLoader load the supertype with the plugin's class loader, not the class loader that loaded the SpotBugs core.

Earlier/LaterSubtypes supports only built-in supertypes (spotbugs#215)
99e407c 
This lets the PluginLoader load the supertype with the plugin's
class loader, not the class loader that loaded the SpotBugs core.
henrik242
henrik242 approved these changes Jun 28, 2017
View reviewed changes
Copy link
Contributor

@henrik242 henrik242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@henrik242 henrik242 merged commit fddcc5e into spotbugs:master Jun 28, 2017
@sewe sewe deleted the issue-215 branch June 28, 2017 07:05
@KengoTODA
Copy link
Member

BTW what is the purpose of this change? Bugfix?

@KengoTODA
Copy link
Member

If so, better to add an entry to CHANGELOG.md.

@sewe
Copy link
Author

sewe commented Jun 28, 2017

BTW what is the purpose of this change? Bugfix?

Yes, EarlierSubtypes/LaterSubtypes didn’t allow you to use your own supertype; you were stuck with the types defined in the SpotBugs JAR. Now you are able to define your own marker interfaces to easily order the detectors in the plugin you contribute; you are no longer stuck with NonReportingDetector and friends.

If so, better to add an entry to CHANGELOG.md.

Will do.

sewe pushed a commit to sewe/spotbugs that referenced this pull request Jun 28, 2017
Update changelog for pull request spotbugs#223
3bdbdaa
@KengoTODA
Copy link
Member

Thank you :)

KengoTODA pushed a commit that referenced this pull request Jun 29, 2017
@KengoTODA
Update changelog for pull request #223
3512a51
@KengoTODA KengoTODA added this to the SpotBugs 3.1.0 milestone Jun 29, 2017
@KengoTODA KengoTODA added the bug label Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrik242 henrik242 henrik242 approved these changes

Assignees

@sewe sewe

Labels
bug
Projects
None yet
Milestone
SpotBugs 3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sewe @KengoTODA @henrik242