Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiplatform GHA build #2507

Merged
merged 4 commits into from Aug 17, 2023
Merged

Multiplatform GHA build #2507

merged 4 commits into from Aug 17, 2023

Conversation

JuditKnoll
Copy link
Collaborator

This PR extends the build github action running on Linux with Windows and MacOS platforms, complete with the eclipsePlugin build.
There is one downside to this approach: the builds on different platforms are tied together, so if any of them fails, the others are cancelled. If it would be separated to different jobs I think the builds weren't tied together like this, but that way the code would contain too much code repetition. Please let me know, if it would be better the other way (or if you know any other way to separate the jobs)!
Didn't add anything to the CHANGELOG.md, since this doesn't change SpotBugs code, it's only a github action change. Let me know, if you think I should.


Make sure these boxes are checked before submitting your PR -- thank you!

  • Added an entry into CHANGELOG.md if you have changed SpotBugs code

@gtoison
Copy link
Contributor

gtoison commented Aug 11, 2023

I think you can use continue-on-error if you don't want that all jobs are cancelled when one of them fails: https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#handling-failures

@JuditKnoll
Copy link
Collaborator Author

I think you can use continue-on-error if you don't want that all jobs are cancelled when one of them fails: https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#handling-failures

Thank you, @gtoison ! This solves the problem. See the checks for the 001332e commit, where the Windows fails before the MacOS finishes, but it doesn't get cancelled.

Now, the build is successful on all three platforms, but the Read the docs fails. I don't think I made any changes which should cause the Read the docs to fail. Does anyone have any idea why it fails? Is it a problem?

@gtoison
Copy link
Contributor

gtoison commented Aug 15, 2023

Looks like readthedocs requires a new "v2" configuration: https://blog.readthedocs.com/migrate-configuration-v2/

Copy link
Contributor

@gtoison gtoison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@hazendaz hazendaz self-assigned this Aug 17, 2023
@hazendaz hazendaz merged commit 93ff3cf into spotbugs:master Aug 17, 2023
6 checks passed
@JuditKnoll JuditKnoll deleted the gha-multiplatform-build branch September 1, 2023 14:52
@hazendaz hazendaz added this to the SpotBugs 4.8.0 milestone Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants