Fix for IndexOutOfBoundsException in sarif placeholder #2649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the bug description has a placeholder for a non-existent annotation the sarif placeholder class causes a IndexOutOfBoundsException
edu.umd.cs.findbugs.FindBugsMessageFormat#format handles the case when the bug description contains a place holder but the corresponding annotation does not exist. Let the sarif placeholder handle this the same way
hazendaz
reviewed
Oct 17, 2023
| @@ -28,6 +28,12 @@ class Placeholder { | |||
|
|
|||
| @NonNull | |||
| String toArgument(List<? extends BugAnnotation> bugAnnotations, @Nullable ClassAnnotation primaryClass) { | |||
| return bugAnnotations.get(index).format(key, primaryClass); | |||
| if (index < 0) { | |||
There was a problem hiding this comment.
@gtoison Can you combine the 'if' here?
There was a problem hiding this comment.
The two look similar but are different (< vs. >), I used the same format as edu.umd.cs.findbugs.FindBugsMessageFormat#format so the same problem will produce a similar output
There was a problem hiding this comment.
Ah, thanks, I looked at that multiple times but wasn't seeing it. All good.
hazendaz
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the bug description has a placeholder for a non-existent annotation the sarif placeholder class causes a IndexOutOfBoundsException
This is most likely a side effect of #2627
Fixes #2632