omit null value in SARIF taxonomies property #2745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR 😄 Can you please add some tests? |
|
Sure 🙂 I've added a small test that checks for correct values (or absence thereof) of empty taxonomies and results. |
JuditKnoll
reviewed
Dec 7, 2023
spotbugs-tests/src/test/java/edu/umd/cs/findbugs/sarif/SarifBugReporterTest.java
Outdated
Show resolved
Hide resolved
JuditKnoll
approved these changes
Dec 7, 2023
hazendaz
reviewed
Dec 9, 2023
spotbugs-tests/src/test/java/edu/umd/cs/findbugs/sarif/SarifBugReporterTest.java
Outdated
Show resolved
Hide resolved
# Conflicts: # CHANGELOG.md
ThrawnCA
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a conflict with the SARIF specification regarding
taxonomieswhere SpotBugs would add a null value into the list if no other taxonomy was applicable.The current implementation can create problems with parsers that expect either an empty list or a valid object.
Closes #2744 .
Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code