Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[checkstyle] Bump to 10.12.7, add spring dependency management to fix gradle exclusion defects #2798

Merged
merged 5 commits into from
Jan 20, 2024
Merged

[checkstyle] Bump to 10.12.7, add spring dependency management to fix gradle exclusion defects #2798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
df5a4cf
[checkstyle] Bump to 10.12.7, add spring dependency management to fix…
hazendaz Jan 6, 2024
49515f6
[ci] Fix branch used for coverage to master not release-3.1
hazendaz Jan 6, 2024
e616ac2
[rework] Use a better way to handle checkstyle google collections issue
hazendaz Jan 20, 2024
d41cad7
[ci ] correct spelling
hazendaz Jan 20, 2024
17e8659
[ci] Fix change log
hazendaz Jan 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 5 additions & 4 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@ Currently the versioning policy of this project follows [Semantic Versioning v2.
- Do not report BC_UNCONFIRMED_CAST for Java 21's type switches ([#2813](https://github.com/spotbugs/spotbugs/pull/2813))
- Remove AppleExtension library (note: menus slightly changed) ([#2823](https://github.com/spotbugs/spotbugs/pull/2823))

### Build
- Fix sonar coverage for project ([#2796](https://github.com/spotbugs/spotbugs/issues/2796))
- Upgraded the build to compile bug samples using Java 21 language features ([#2813](https://github.com/spotbugs/spotbugs/pull/2813))

### Added
- New detector `MultipleInstantiationsOfSingletons` and introduced new bug types:
- `SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR` is reported in case of a non-private constructor,
Expand All @@ -34,6 +30,11 @@ Currently the versioning policy of this project follows [Semantic Versioning v2.
### Changed
- Minor cleanup in connection with slashed and dotted names ([#2805](https://github.com/spotbugs/spotbugs/pull/2805))

### Build
- Fix sonar coverage for project ([#2796](https://github.com/spotbugs/spotbugs/issues/2796))
- Upgraded the build to compile bug samples using Java 21 language features ([#2813](https://github.com/spotbugs/spotbugs/pull/2813))
- Add 'configurations.checkstyle resolution starategy' to control bug in gradle on exclusions not being excluded properly as seen in checkstyle usage. See https://github.com/checkstyle/checkstyle/issues/14211 for more information. ([#2798](https://github.com/spotbugs/spotbugs/issues/2798))

## 4.8.3 - 2023-12-12
### Fixed
- Fix FP in CT_CONSTRUCTOR_THROW when the finalizer does not run, since the exception is thrown before java.lang.Object's constructor exits for checked exceptions ([#2710](https://github.com/spotbugs/spotbugs/issues/2710))
Expand Down
8 changes: 7 additions & 1 deletion gradle/checkstyle.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
// Setup checkstyle
apply plugin: 'checkstyle'

configurations.checkstyle {
resolutionStrategy.capabilitiesResolution.withCapability("com.google.collections:google-collections") {
select("com.google.guava:guava:0")
}
}

checkstyle {
toolVersion '10.12.5'
toolVersion '10.12.7'
hazendaz marked this conversation as resolved.
Show resolved Hide resolved
ignoreFailures false
configFile file("$rootDir/spotbugs/etc/checkstyle.xml") // TODO : This config file is lame and should be moved out...
}
Expand Down