Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated renovate setup / Make sure files follow GIT convention and end with empty end of line #2889

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

hazendaz
Copy link
Member

@hazendaz hazendaz commented Mar 4, 2024

No description provided.

@hazendaz
Copy link
Member Author

hazendaz commented Mar 4, 2024

Hi All, I don't expect everyone to notice the EOL markers that often as pulls come in with then and the process 'git bash script' to fix them takes forever. So I just plan to do this myself typically around time we go for a release. The point is that when git performs diffs, if it does not have end of line marker, it has to add one so technically its slightly faster to do it appropriately but its often easily missed.

@hazendaz
Copy link
Member Author

hazendaz commented Mar 4, 2024

For the renovate item, they put a notice out and are supposed to eventually fix those on their own PRs but still haven't done so. So I mass did some 160 repos I have and just pushing them up when I have time. It makes no real difference as it was just a naming change.

That all said I did not bother with change log because technically nothing changes here as completely no-op.

@hazendaz hazendaz self-assigned this Mar 6, 2024
@hazendaz hazendaz merged commit a5a79c9 into spotbugs:master Mar 6, 2024
15 checks passed
@hazendaz hazendaz added this to the SpotBugs 4.8.4 milestone Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants