New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix classpaths after asm and bcel updates, fixes #405 #407

Merged
merged 2 commits into from Sep 26, 2017

Conversation

Projects
None yet
2 participants
@iloveeclipse
Member

iloveeclipse commented Sep 25, 2017

@richardfearn : can you please check this PR?

@iloveeclipse iloveeclipse requested a review from KengoTODA Sep 25, 2017

@KengoTODA

This comment has been minimized.

Show comment
Hide comment
@KengoTODA

KengoTODA Sep 26, 2017

Member

@iloveeclipse I proposed one fix to generate list of jar files automatically. Here is generated spotbugs/build/libs/META-INF/MANIFEST.MF:

Manifest-Version: 1.0
Main-Class: edu.umd.cs.findbugs.LaunchAppropriateUI
Bundle-Version: 3.1.0-SNAPSHOT
Class-Path: asm-analysis-6.0.jar asm-commons-6.0.jar asm-xml-6.0.jar a
 sm-util-6.0.jar asm-tree-6.0.jar asm-6.0.jar bcel-6.1.jar jcip-annota
 tions-1.0.jar dom4j-1.6.1.jar jaxen-1.1.6.jar commons-lang-2.6.jar jF
 ormatString-3.0.0.jar spotbugs-annotations.jar xml-apis-1.0.b2.jar js
 r305-3.0.1.jar
Automatic-Module-Name: com.github.spotbugs.spotbugs

This change adds two more jar files: xml-apis-1.0.b2.jar and jcip-annotations-1.0.jar which is also distributed by SpotBugs.

Member

KengoTODA commented Sep 26, 2017

@iloveeclipse I proposed one fix to generate list of jar files automatically. Here is generated spotbugs/build/libs/META-INF/MANIFEST.MF:

Manifest-Version: 1.0
Main-Class: edu.umd.cs.findbugs.LaunchAppropriateUI
Bundle-Version: 3.1.0-SNAPSHOT
Class-Path: asm-analysis-6.0.jar asm-commons-6.0.jar asm-xml-6.0.jar a
 sm-util-6.0.jar asm-tree-6.0.jar asm-6.0.jar bcel-6.1.jar jcip-annota
 tions-1.0.jar dom4j-1.6.1.jar jaxen-1.1.6.jar commons-lang-2.6.jar jF
 ormatString-3.0.0.jar spotbugs-annotations.jar xml-apis-1.0.b2.jar js
 r305-3.0.1.jar
Automatic-Module-Name: com.github.spotbugs.spotbugs

This change adds two more jar files: xml-apis-1.0.b2.jar and jcip-annotations-1.0.jar which is also distributed by SpotBugs.

@iloveeclipse

This comment has been minimized.

Show comment
Hide comment
@iloveeclipse

iloveeclipse Sep 26, 2017

Member

@KengoTODA : can we merge this now?

Member

iloveeclipse commented Sep 26, 2017

@KengoTODA : can we merge this now?

@KengoTODA

LGTM

@KengoTODA KengoTODA merged commit 710a135 into master Sep 26, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
sonarqube SonarQube reported no issues

@KengoTODA KengoTODA deleted the issue405 branch Sep 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment