Load version from Manifest #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jsotuyod
commented
Nov 30, 2016
jsotuyod
commented
- Simplify the code, get rid of a bunch of version flags that had no real value
- Resolve issues raised at Kill ant & maven #40 (comment)
- Simplify the code, get rid of a bunch of version flags that had no real value
jsotuyod
force-pushed
the
fix-properties
branch
from
54bbd87
to
013dc18
Compare
|
whats the checking for file protocol for? Should work otherwise, right? what would the other be, jnlp? |
|
@mebigfatguy actually, I'm not sure (it was already like that in the code, I just load the manifest instead of If we are not running from the jar (running from IDE), the getResourceAsStream would return null. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.