Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for JDT illegal signatures #55

Merged
merged 2 commits into from
Dec 3, 2016
Merged

Workaround for JDT illegal signatures #55

merged 2 commits into from
Dec 3, 2016

Conversation

jsotuyod
Copy link
Member

@jsotuyod jsotuyod commented Dec 2, 2016

@jsotuyod jsotuyod added this to the SpotBugs 3.1.0 milestone Dec 2, 2016
@jsotuyod jsotuyod mentioned this pull request Dec 2, 2016
Closed
@jsotuyod jsotuyod added the WIP label Dec 3, 2016
@jsotuyod
Add more and beter tests for JDT signatures
a4ca813 
 - Cover all 3 possibilities
 - Fix an issue with GenericUtilities
 - Take the chance to unify 2 different tests classes on the same parser
@jsotuyod jsotuyod removed the WIP label Dec 3, 2016
@jsotuyod
Copy link
Member Author

jsotuyod commented Dec 3, 2016

@mebigfatguy there I added test cases for all, !+, !- and !* at a higher level and was able to detect and fix an issue. I know believe this will work as expected.

@mebigfatguy mebigfatguy merged commit 51b4a32 into master Dec 3, 2016
@jsotuyod jsotuyod deleted the support-jdt-signatures branch December 3, 2016 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mebigfatguy mebigfatguy mebigfatguy approved these changes

Assignees

@henrik242 henrik242

@mebigfatguy mebigfatguy

@KengoTODA KengoTODA

@h3xstream h3xstream

@ThrawnCA ThrawnCA

Labels
bug Java-8
Projects
None yet
Milestone
SpotBugs 3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jsotuyod @mebigfatguy @henrik242 @KengoTODA @h3xstream @ThrawnCA