Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runMain: Don't print exit code information when -quiet is passed #714

Closed
wants to merge 2 commits into from

Conversation

philipl
Copy link
Contributor

@philipl philipl commented Jul 30, 2018

Today, it's impossible to run spotbugs where the exit code is set
and output is fully suppressed. It seems reasonable that -quiet
should suppress the exit code related output, which is not normally
very interesting.


Make sure these boxes are checked before submitting your PR -- thank you!

  • Added an entry into CHANGELOG.md if you have changed SpotBugs code

Today, it's impossible to run spotbugs where the exit code is set
and output is fully suppressed. It seems reasonable that -quiet
should suppress the exit code related output, which is not normally
very interesting.
ThrawnCA
ThrawnCA previously approved these changes Jul 31, 2018
Copy link
Contributor

@ThrawnCA ThrawnCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should all be eventually replaced with a proper logging framework.

Copy link
Member

@KengoTODA KengoTODA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@KengoTODA KengoTODA added this to the SpotBugs 3.1.7 milestone Aug 6, 2018
@KengoTODA
Copy link
Member

Wmm GitHub's conflict management is still buggy... It still says "This branch cannot be rebased due to conflicts" even after my commit 72d807e.

Let me create a new PR from the latest release-3.1 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants